Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Use{user_identifier} over deprecated{username} in factories#53529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@tcitworld
Copy link
Contributor

QA
Branch?7.0
Bug fix?yes
New feature?no
Deprecations?no
Issues
LicenseMIT

In SF 7.0, the deprecated{username} placeholder was removed in favor of{user_identifier} (in#50866). However, the default values for thefilter anddn_string parameters still contained{username} instead of the updated key.

This PR changes the value to the new updated key

In SF 7.0, the deprecated {username} placeholder was removed in favor of {user_identifier} (insymfony#50866).However, the default values for the filter and dn_string parameters still contained {username} instead of the updated key.This PR changes the value to the new updated keySigned-off-by: Thomas Citharel <tcit@tcit.fr>
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@tcitworld
Copy link
ContributorAuthor

CI failure looks unrelated

@OskarStarkOskarStark changed the titlefix(ldap): replace {username} with {user_identifier} in LDAP factories[Ldap] Use{user_identifier} over deprecated{username} in factoriesJan 13, 2024
@carsonbotcarsonbot changed the title[Ldap] Use{user_identifier} over deprecated{username} in factoriesUse{user_identifier} over deprecated{username} in factoriesJan 18, 2024
@fabpot
Copy link
Member

Thank you@tcitworld.

@fabpotfabpot merged commit3368c3f intosymfony:7.0Jan 18, 2024
@tcitworldtcitworld deleted the fix-ldap-filter-default-value branchJanuary 18, 2024 08:36
@fabpotfabpot mentioned this pull requestJan 31, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tcitworld@carsonbot@fabpot
[8]ページ先頭
©2009-2025 Movatter.jp