Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[VarDumper] FixesTyped property Symfony\Component\VarDumper\Dumper\CliDumper::$colors must not be accessed before initialization#53521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.0fromcrynobone:patch-1
Jan 12, 2024

Conversation

crynobone
Copy link
Contributor

@crynobonecrynobone commentedJan 12, 2024•
edited
Loading

QA
Branch?7.0
Bug fix?yes
New feature?no
Deprecations?no
IssuesN/A
LicenseMIT

Fixes the following error:

CleanShot 2024-01-12 at 16 27 25

Other methods in the class start with$this->colors ??= $this->supportsColors();. I believe this should have the same code.

@carsonbotcarsonbot added this to the7.0 milestoneJan 12, 2024
@crynobonecrynobone changed the title[VarDumper] Fixes ` Typed property Symfony\Component\VarDumper\Dumper\CliDumper::…[VarDumper] FixesTyped property Symfony\Component\VarDumper\Dumper\CliDumper::$colors must not be accessed before initializationJan 12, 2024
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

if we're missing an initialization here, it means the patch should likely go on 5.4

@crynobone
Copy link
ContributorAuthor

if we're missing an initialization here, it means the patch should likely go on 5.4

Not exactly, since 7.0 changed fromprotected $colors; toprotected bool $colors;.

…CliDumper::$colors must not be accessed before initialization`
@fabpot
Copy link
Member

Thank you@crynobone.

@fabpotfabpot merged commit63d9a53 intosymfony:7.0Jan 12, 2024
@crynobonecrynobone deleted the patch-1 branchJanuary 14, 2024 23:36
xabbuh added a commit that referenced this pull requestJan 16, 2024
…r` (nicolas-grekas)This PR was merged into the 5.4 branch.Discussion---------- [VarDumper] Fix missing colors initialization in `CliDumper`| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        | -| License       | MITBackporting#53521 to 5.4Commits-------6817109 [VarDumper] Fix missing colors initialization in CliDumper
@fabpotfabpot mentioned this pull requestJan 31, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@fabpotfabpotfabpot approved these changes

@xabbuhxabbuhxabbuh approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.

5 participants
@crynobone@fabpot@nicolas-grekas@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp