Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] [CacheWarmer] RunConfigBuilderCacheWarmer during execution ofbin/console cache:warmup#53512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
ArtemBrovko wants to merge1 commit intosymfony:6.4fromArtemBrovko:fix_53496

Conversation

ArtemBrovko
Copy link
Contributor

@ArtemBrovkoArtemBrovko commentedJan 11, 2024•
edited
Loading

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#53496
LicenseMIT

ConfigBuilderCacheWarmer is not called when executingbin/console cache:warmup
This is an attempt to fix linked issue.

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "7.1 for features / 5.4, 6.3, 6.4, or 7.0 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

ArtemBrovko reacted with thumbs up emoji

@carsonbotcarsonbot changed the title[CacheWarmer] [FrameworkBundle] RunConfigBuilderCacheWarmer during execution ofbin/console cache:warmup[FrameworkBundle] [CacheWarmer] RunConfigBuilderCacheWarmer during execution ofbin/console cache:warmupJan 11, 2024
@nicolas-grekas
Copy link
Member

I'm proposing#53672 instead, can you please give it a try?

@nicolas-grekas
Copy link
Member

Thanks for submitting. Please let me know if you're still having the issue.

ArtemBrovko reacted with thumbs up emoji

nicolas-grekas added a commit that referenced this pull requestJan 29, 2024
…-optional (nicolas-grekas)This PR was merged into the 6.4 branch.Discussion----------[FrameworkBundle] `ConfigBuilderCacheWarmer` should be non-optional| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        |Fix#53496| License       | MITReplaces#53512This became apparent after#50391, where the warmer is run only when compiling the container. Before, it didn't really matter.Commits-------8bd2ff8 [FrameworkBundle] ConfigBuilderCacheWarmer should be non-optional
@ArtemBrovko
Copy link
ContributorAuthor

Yes, now it works. Thanks!

@ArtemBrovkoArtemBrovko deleted the fix_53496 branchApril 11, 2024 12:25
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

3 participants
@ArtemBrovko@carsonbot@nicolas-grekas
[8]ページ先頭
©2009-2025 Movatter.jp