Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Validator] Add PHPDoc toGroupSequence attribute class and properties#53428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
kzorluoglu wants to merge2 commits intosymfony:7.4Choose a base branch
base:7.4
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
[Validator] Add PHPDoc toGroupSequence attribute class and properties#53428
kzorluoglu wants to merge2 commits intosymfony:7.4fromkzorluoglu:validator-constraints-attribute-phpdoc-improve
+26 −26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
GroupSequence attribute class and properties #53424GroupSequence attribute class and propertiesUh oh!
There was an error while loading.Please reload this page.
Comment on lines 68 to +69
| * | ||
| * If a class has a group sequence attached, that sequence replaces the | ||
| * "Default" group. When validating that class in the "Default" group, the | ||
| * group sequence is used instead, but still the "Default" group should be | ||
| * cascaded to other objects. | ||
| * @var string|GroupSequence |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
These two lines should be deleted to make the fabbot happy.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds detailed PHPDoc comments to the GroupSequence class in the Symfony\Component\Validator\Constraints namespace. The added documentation includes a comprehensive class description and descriptive comments for each public property and the constructor.
These changes are in response to the issue#51920 and follow the same documentation style and standards as Symfony's existing components.