Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PropertyInfo] Restrict access toPhpStanExtractor based on visibility#53362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@nikophil
Copy link
Contributor

QA
Branch?7.1
Bug fix?no
New feature?yes
Deprecations?no
LicenseMIT

Hi,

this small PR gives a bit more control on whatPhpStanExtractor can see or not, based on the visibility of the property or its accessor.

It's pretty unusual, but sometimes, the getter does not return the same type than the property itself, and before this PR, there was actually no way to extract the type returned by the getter.ReflectionExtractor has this granularity, but it cannot read complex PhpDoc types.

@nikophilnikophilforce-pushed theproperty-info/visibility-in-phpstan-extractor branch fromfc8e374 to09bfe6fCompareJanuary 3, 2024 09:01
Copy link
Contributor

@KorbeilKorbeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It looks good to me 👍

Copy link
Member

@dunglasdunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Overall, LGTM!

nikophil reacted with thumbs up emoji
@nikophilnikophilforce-pushed theproperty-info/visibility-in-phpstan-extractor branch from09bfe6f toc970f96CompareJanuary 5, 2024 09:18
@OskarStarkOskarStark changed the title[PropertyInfo] restrict access to PhpStanExtractor based on visibility[PropertyInfo] Restrict access toPhpStanExtractor based on visibilityJan 5, 2024
@nikophilnikophilforce-pushed theproperty-info/visibility-in-phpstan-extractor branch 2 times, most recently from34d2ad9 toa03f5ecCompareJanuary 8, 2024 10:14
@nikophilnikophilforce-pushed theproperty-info/visibility-in-phpstan-extractor branch froma03f5ec toe3ec55fCompareJanuary 31, 2024 11:05
@fabpot
Copy link
Member

Thank you@nikophil.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dunglasdunglasdunglas left review comments

@OskarStarkOskarStarkOskarStark left review comments

@fabpotfabpotfabpot approved these changes

+1 more reviewer

@KorbeilKorbeilKorbeil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

6 participants

@nikophil@fabpot@dunglas@Korbeil@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp