NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Notifier] Add Pusher.com bridge#53267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

OskarStark wants to merge26 commits intosymfony:7.1fromOskarStark:pusher-notification-2

Closed

[Notifier] Add Pusher.com bridge#53267

OskarStark wants to merge26 commits intosymfony:7.1fromOskarStark:pusher-notification-2

Conversation

Copy link

Contributor

OskarStark commentedDec 28, 2023

Q	A
Branch?	7.1
Bug fix?	no
New feature?	yes
Deprecations?	no
Issues	--
License	MIT

Replaces#48203 becauseAllow edits from Maintainer box is unchecked

OskarStark self-assigned this

Dec 28, 2023

carsonbot added Status: Needs Review Feature Notifier labels

Dec 28, 2023

carsonbot added this to the7.1 milestone

Dec 28, 2023

OskarStark mentioned this pull request

Dec 28, 2023

[Notifier] Add Pusher Notifier Bridge#48203

Closed

bitgandtter added18 commits

December 28, 2023 22:51

feat: add Pusher symfony notifier bridge

7d4754e

fix: composer.json package name

b2d65b1

fix: LICENSE and CHANGELOG.md

aa58ad2

chore: apply fabbot

caf6227

chore: apply fabbot

9459855

chore: apply fabbot

f0d3e63

chore: work on PR comments

6d733d9

chore: drop declare strict types

606fe02

chore: small format changes

5e8bdd6

fix: add pusher package to main composer.json to fix tests

389338f

chore: set PusherRecipientInterface as typehint of asPushMessage method

7e039d6

chore: remove@internal annotation from testschore: add footer to README.mdchore: apply PR comments

chore: set RecipientInterface as typehint of asPushMessage method

0718f59

chore: fabbot

dc296b0

fix: LICENSE

4111ae7

chore: rebase forsymfony#49385

5dcf3b5

chore: apply comments fromsymfony#49385

b7386b8

feat: drop autoconfigure tag from transport factory

e427702

feat: configure pusher notifier on framework bundle

chore: drop extra - on CHANGELOG.md

974c996

fix: drop sensitive information from toString method on transport

OskarStark force-pushed thepusher-notification-2 branch fromf034b8b to974c996Compare

December 28, 2023 21:53

OskarStark added5 commits

December 28, 2023 22:54

-

85e2bf4

-

cf28c50

-

f999080

-

25522aa

-

bddf6ef

OskarStark added3 commits

December 28, 2023 23:01

-

d69148a

-

52482a1

-

69923a2

Copy link

ContributorAuthor

OskarStark commentedDec 28, 2023

I have mixed feelings about this bridge, code looks OK now after some fixes, but injecting the build client feels weird. In other bridges we do not depend on third party libraries.
I didn't try this bridge, and don't have the time to implement the plain API.

If someone want to take over and need this bridge, feels free to use this PR as a starting point.

Closing here