Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] [OneSignal] Add support for sending to external user ids#53262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@KDederichs
Copy link
Contributor

QA
Branch?7.1
Bug fix?no
New feature?yes
Deprecations?no
IssuesFix#50779
LicenseMIT

As discussed in#53248, here's the feature PR against 7.1.

This introduces a newisExternalUserId() option to indicate that the receiver is an external user id.

At the same time it also replaces the deprecatedinclude_player_ids option.

@carsonbotcarsonbot added this to the7.1 milestoneDec 28, 2023
@carsonbotcarsonbot changed the title[Notifier][OneSignal] Add support for sending to external user ids[Notifier] [OneSignal] Add support for sending to external user idsDec 28, 2023
@KDederichsKDederichsforce-pushed thefeat/onesignal_external_user_ids branch 3 times, most recently from33ec1c0 to149d25dCompareDecember 28, 2023 18:48
Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just some minor comments

@KDederichsKDederichsforce-pushed thefeat/onesignal_external_user_ids branch from149d25d to533a831CompareDecember 29, 2023 11:11
@OskarStark
Copy link
Contributor

Thank you@KDederichs.

@OskarStarkOskarStark merged commit366baef intosymfony:7.1Dec 29, 2023
@fabpotfabpot mentioned this pull requestMay 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

+1 more reviewer

@norkunasnorkunasnorkunas left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

Support for external user ids in OneSignal Notifier

4 participants

@KDederichs@OskarStark@norkunas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp