Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpKernel] fix "Cannot redeclare renderSymfonyLogoSvg()" inside phpunit tests#53239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.0fromdavidesigner:7.0
Dec 28, 2023
Merged

Conversation

@davidesigner
Copy link
Contributor

@davidesignerdavidesigner commentedDec 27, 2023•
edited
Loading

QA
Branch?7.0
Bug fix?yes
New feature?no
Deprecations?no
IssuesN/A
LicenseMIT

In a PHPUnit test case with dataProvider, there was a fatal error:

Compile Error: Cannot redeclare renderSymfonyLogoSvg() (previously declared in /vendor/symfony/http-kernel/Resources/welcome.html.php:219) (500 Internal Server Error)

This include_once fix the error.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

@xabbuh
Copy link
Member

LGTM, but should probably be done on 5.4, right?

Copy link
Member

@xabbuhxabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ah no, the function was introduced in#51771 in 7.0.

davidesigner reacted with thumbs up emoji
@fabpot
Copy link
Member

Thank you@davidesigner.

@fabpotfabpot merged commitc1fd862 intosymfony:7.0Dec 28, 2023
@fabpotfabpot mentioned this pull requestDec 30, 2023
nicolas-grekas added a commit that referenced this pull requestJan 31, 2024
…peMC)This PR was merged into the 7.0 branch.Discussion----------[HttpKernel] Fix including welcome page multiple times| Q             | A| ------------- | ---| Branch?       | 7.0| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        |Fix#53686| License       | MITReverts#53239 & switches to using closures instead.Commits-------4e55227 [HttpKernel] Fix including welcome page multiple times
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@davidesigner@carsonbot@xabbuh@fabpot
[8]ページ先頭
©2009-2025 Movatter.jp