NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[HttpKernel] Add support for custom HTTP status code for the`#[MapQueryParameter]` attribute#53209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:7.1fromovidiuenache:fix_52782

Jan 2, 2024

Merged

[HttpKernel] Add support for custom HTTP status code for the`#[MapQueryParameter]` attribute#53209

nicolas-grekas merged 1 commit intosymfony:7.1fromovidiuenache:fix_52782

Jan 2, 2024

Conversation

Copy link

Contributor

ovidiuenache commentedDec 25, 2023•
edited
Loading

Q	A
Branch?	7.1
Bug fix?	no
New feature?	yes
Deprecations?	no
Issues	#52782
License	MIT

Issue#52782 was created where the need to have a custom HTTP status code for the MapQueryParameter attribute was stated. As part of the discussion,@nicolas-grekas suggested an approach similar to the implementation of the MapQueryString attribute where such a status code can be provided in the attribute's constructor.

I believe having the possibility to control the status code returned for an invalid and non-nullable parameter with no default value would be a great addition so I took the liberty to create this PR.

This change is backward compatible.

carsonbot added Status: Needs Review Bug HttpKernel labels

Dec 25, 2023

carsonbot added this to the6.4 milestone

Dec 25, 2023

Copy link

carsonbot commentedDec 25, 2023

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

ovidiuenache force-pushed thefix_52782 branch from9db9710 tocc784f6Compare

December 25, 2023 21:07

nicolas-grekas mentioned this pull request

Dec 26, 2023

[HttpKernel] AddHttpException::fromStatusCode()#53212

Merged

nicolas-grekas reviewed

Dec 26, 2023

View reviewed changes

src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/QueryParameterValueResolver.php OutdatedShow resolvedHide resolved

ovidiuenache force-pushed thefix_52782 branch fromcc784f6 to94836b8Compare

December 26, 2023 16:41

ovidiuenache requested review fromOskarStark,chalasr,dunglas,jderusse,kbond,lyrixx,welcoMattic,xabbuh andyceruto ascode owners

December 26, 2023 16:41

ovidiuenache changed the base branch from6.4 to7.1

December 26, 2023 16:42

OskarStark changed the title~~[HttpKernel] Add support for custom HTTP status code for the MapQueryParameter attribute~~[HttpKernel] Add support for custom HTTP status code for the `#[MapQueryParameter] attribute

Dec 26, 2023

OskarStark modified the milestones:6.4,7.1

Dec 26, 2023

OskarStark changed the title~~[HttpKernel] Add support for custom HTTP status code for the `#[MapQueryParameter] attribute~~[HttpKernel] Add support for custom HTTP status code for the#[MapQueryParameter] attribute

Dec 26, 2023

OskarStark reviewed

Dec 26, 2023

View reviewed changes

src/Symfony/Component/HttpKernel/CHANGELOG.md OutdatedShow resolvedHide resolved

ovidiuenache force-pushed thefix_52782 branch from94836b8 to454d3aaCompare

December 26, 2023 21:26

nicolas-grekas added a commit that referenced this pull request

Dec 27, 2023

feature#53212[HttpKernel] AddHttpException::fromStatusCode()(ni…

1d35045

…colas-grekas)This PR was merged into the 7.1 branch.Discussion----------[HttpKernel] Add `HttpException::fromStatusCode()`| Q             | A| ------------- | ---| Branch?       | 7.1| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Issues        | -| License       | MITA small helper idea that popped up when reviewing#53209Commits-------98f4fa1 [HttpKernel] Add `HttpException::fromStatusCode()`