Sometimes the locale codes may be different from thecodes used in the Crowdin API. This will cause API errors because the wrong code is passed in the upload and download translation requests. There was already a fix (#50040), but it only works partially.

The suggested approach uses thelanguage mapping configured in the Crowdin project. If the locale code and the crowdin code are different, the user needs to configure the language mapping in the Crowdin project.

Documentation -symfony/symfony-docs#19325

andrii-bodnar requested a review fromwelcoMattic as acode owner

December 21, 2023 17:59

carsonbot added Status: Needs Review Bug Translation labels

Dec 21, 2023

carsonbot added this to the6.4 milestone

Dec 21, 2023

Copy link

carsonbot commentedDec 21, 2023

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.4, 7.0".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

andrii-bodnar force-pushed thefix/crowdin-language-mapping branch from2fa3abe tod4f467cCompare

December 21, 2023 18:02

andrii-bodnar marked this pull request as draft

December 22, 2023 07:31

OskarStark changed the title~~[Translation] Crowdin Bridge: use the project language mapping~~[Translation][Crowdin] Use project language mapping

Dec 22, 2023

andrii-bodnar marked this pull request as ready for review

December 22, 2023 08:12

andrii-bodnar mentioned this pull request

Dec 22, 2023

[Translation] [Crowdin] Add a tip about language mappingsymfony/symfony-docs#19325

Merged

nicolas-grekas modified the milestones:6.4,6.3

Dec 26, 2023

[Translation] Crowdin Bridge: use the project language mapping

a1d2f67

nicolas-grekas changed the base branch from6.4 to6.3

December 26, 2023 14:58

nicolas-grekas requested review fromOskarStark,chalasr,dunglas,jderusse,kbond,lyrixx,xabbuh andyceruto ascode owners

December 26, 2023 14:58

nicolas-grekas force-pushed thefix/crowdin-language-mapping branch fromd4f467c toa1d2f67Compare

December 26, 2023 14:58

Copy link

Member

nicolas-grekas commentedDec 26, 2023

Thank you@andrii-bodnar.

nicolas-grekas merged commitc529c4e intosymfony:6.3

Dec 26, 2023

andrii-bodnar deleted the fix/crowdin-language-mapping branch

December 26, 2023 15:01

OskarStark added a commit to symfony/symfony-docs that referenced this pull request

Dec 26, 2023

minor#19325[Translation] [Crowdin] Add a tip about language mapping…

92c1397

… (andrii-bodnar)This PR was merged into the 6.3 branch.Discussion----------[Translation] [Crowdin] Add a tip about language mappingRelated PR -symfony/symfony#53178<!--If your pull request fixes a BUG, use the oldest maintained branch that containsthe bug (seehttps://symfony.com/releases for the list of maintained branches).If your pull request documents a NEW FEATURE, use the same Symfony branch wherethe feature was introduced (and `6.x` for features of unreleased versions).-->Commits-------e9c44f4 [Translation] Add a tip about Crowdin language mapping