Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Cache] Fix CI failing tests#53124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@alexandre-daubois
Copy link
Member

@alexandre-dauboisalexandre-daubois commentedDec 18, 2023•
edited
Loading

QA
Branch?7.1
Bug fix?yes
New feature?no
Deprecations?no
Issues-
LicenseMIT

Fixes CI,AbstractAdapter::createConnection checks the bucket support before falling back to Collection when the DSN starts withcouchbase. Should fix CI in all versions with#53054

@carsonbotcarsonbot added this to the7.1 milestoneDec 18, 2023
@alexandre-dauboisalexandre-dauboisforce-pushed thefix-deprec-warning branch 2 times, most recently fromc9388c6 toa385bc4CompareDecember 18, 2023 10:30
@alexandre-dauboisalexandre-daubois changed the title[Cache] Fix failing test[Cache] Fix failing testsDec 18, 2023
@alexandre-dauboisalexandre-daubois changed the title[Cache] Fix failing tests[Cache] Fix CI failing testsDec 18, 2023
@nicolas-grekas
Copy link
Member

Thank you@alexandre-daubois.

@nicolas-grekasnicolas-grekas merged commitf62c869 intosymfony:7.1Dec 18, 2023
fabpot added a commit that referenced this pull requestMay 21, 2024
…hbase (derrabus)This PR was merged into the 7.1 branch.Discussion----------[Cache] Fix irrelevant deprecation when connecting to Couchbase| Q             | A| ------------- | ---| Branch?       | 7.1| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        | Follows#53124| License       | MITWhen creating a connection for Couchbase, we currently always trigger a deprecation that we cannot opt out of. The reason is that `AbstractAdapter` calls the the `isSupported()` method of the deprecated `CouchbaseBucketAdapter` class before deciding in favor of its non-deprecated replacement `CouchbaseCollectionAdapter`.Commits-------817420f [Cache] Fix CouchbaseCollectionAdapterTest
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

3 participants

@alexandre-daubois@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp