Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[VarDumper] Added default message for dd function#53123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@shamimulalam
Copy link
Contributor

@shamimulalamshamimulalam commentedDec 18, 2023•
edited
Loading

QA
Branch?7.1
Bug fix?no
New feature?yes
Deprecations?no
Issues
LicenseMIT

This will facilitate writing empty dd() statements during unorthodox debugging in the code. It will be helpful for both novice and experienced developers.

skigun reacted with heart emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "7.1 for features".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@carsonbotcarsonbot changed the titleAdded default message for dd function[VarDumper] Added default message for dd functionDec 18, 2023
}

if (empty($vars)) {
VarDumper::dump('Dumped!');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should we use 🐛 like in thedump() function?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It's not bug! So i think, we shouldn't use🐛 this. We can use different emoji. What about 🐞 this? Or can you suggest something else?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

we should be consistent with what we do in dump:

VarDumper::dump(newScalarStub('🐛'))

shamimulalam reacted with thumbs up emoji
@fabpotfabpotforce-pushed theadd_default_message_for_dd_method branch from5694cb5 to857db8fCompareDecember 18, 2023 20:10
@fabpot
Copy link
Member

Thank you@shamimulalam.

shamimulalam reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@alexandre-dauboisalexandre-dauboisAwaiting requested review from alexandre-daubois

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

6 participants

@shamimulalam@carsonbot@fabpot@nicolas-grekas@alexandre-daubois@xabbuh
[8]ページ先頭
©2009-2025 Movatter.jp