Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] Add Unifonic notifier bridge#53092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.1fromseferov:notifier-unifonic
Dec 17, 2023

Conversation

@seferov
Copy link
Contributor

QA
Branch?7.1
Bug fix?no
New feature?yes
Deprecations?no
Issues-
LicenseMIT

Comment on lines 28 to 29
return (new UnifonicTransport('S3cr3t', 'Sender', $client ?? new MockHttpClient()))
->setHost($host);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
return (newUnifonicTransport('S3cr3t','Sender',$client ??newMockHttpClient()))
->setHost($host);
return (newUnifonicTransport('S3cr3t','Sender',$client ??newMockHttpClient()))->setHost($host);


public function testSendSuccess()
{
$response = $this->createMock(ResponseInterface::class);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you useMockResponse/JsonMockResponse instead?

Copy link
Contributor

@OskarStarkOskarStark left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for your contribution, this is much appreciated. Please check my comments, thanks.

In parallel, we also need a PR againstsymfony/symfony-docs andsymfony/recipes-contrib

seferov reacted with thumbs up emoji
@fabpot
Copy link
Member

Thank you@seferov.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

4 participants

@seferov@fabpot@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp