Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] Add Bluesky notifier bridge#53083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.1fromNyholm:bluesky
Dec 15, 2023
Merged

Conversation

@Nyholm
Copy link
Member

@NyholmNyholm commentedDec 14, 2023•
edited
Loading

QA
Branch?7.1
Bug fix?no
New feature?yes
Deprecations?no
Issues
LicenseMIT

I would love if Symfony posted their blog posts onhttps://bsky.app/profile/symfony.bsky.social at some point in the future. I hope this contribution will be a small step towards that.

If someone wants to verify this, I am happy to give out invite codes.

https://bsky.app/profile/nyholm.bsky.social/post/3kgjnhmh4nh2i

I've implemented support for mention and links. Support for images and replies are left outside of the scope for this PR.

GromNaN reacted with thumbs up emoji
@carsonbotcarsonbot added this to the7.1 milestoneDec 14, 2023
@carsonbotcarsonbot changed the title[Notifier][Bluesky] Add Bluesky bridge for notifier[Notifier] [Bluesky] Add Bluesky bridge for notifierDec 14, 2023
Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One minor comment.

It would be helpful if you also provide a docs and recipe PR, thanks

Nyholm reacted with thumbs up emoji
Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This transport needs to be registered in FrameworkBundle

Nyholm reacted with thumbs up emoji
Copy link
Contributor

@OskarStarkOskarStark left a comment•
edited by GromNaN
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

After Fabien's comment and fabbot.io

Thanks

@Nyholm
Copy link
MemberAuthor

Thank you for the reviews. I appreciate you finding all my copy-paste issues.

@OskarStarkOskarStark changed the title[Notifier] [Bluesky] Add Bluesky bridge for notifier[Notifier] Add Bluesky notifier bridgeDec 15, 2023
@fabpot
Copy link
Member

Thank you@Nyholm.

@Nyholm
Copy link
MemberAuthor

Thank you for merging

@fabpot
Copy link
Member

Can you create a PR on symfony/recipes@Nyholm ?

@Nyholm
Copy link
MemberAuthor

Yes. of course. I'll update the docs and a recipe.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

@fabpotfabpotfabpot approved these changes

@xabbuhxabbuhxabbuh approved these changes

+2 more reviewers

@stloydstloydstloyd left review comments

@maxbeckersmaxbeckersmaxbeckers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

7 participants

@Nyholm@fabpot@stloyd@OskarStark@xabbuh@maxbeckers@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp