NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[DoctrineBridge] Add check for lazy object interface#53079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:5.4frommaxbaldanza:var-exporter-doctrine

Dec 19, 2023

Merged

[DoctrineBridge] Add check for lazy object interface#53079

fabpot merged 1 commit intosymfony:5.4frommaxbaldanza:var-exporter-doctrine

Dec 19, 2023

Conversation

Copy link

Contributor

maxbaldanza commentedDec 14, 2023•
edited
Loading

In Symfony 6.4 lazy loading of ghost proxies is used out of the box.

This means if using 6.4 components with the 5.4 version of the doctrine
bridge you get the following error when trying to reset the entity manager:

Resetting a non-lazy manager service is not supported.Declare the "doctrine.orm.default_entity_manager" service as lazy.

The entity manager is set as lazy
already in our case but it extends\Symfony\Component\VarExporter\LazyObjectInterface instead of theLazyLoadingInterface that's expected

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues
License	MIT

Add check for lazy object interface

7ed961e

In Symfony 6.4 lazy loading of ghostproxies is the default.This means if using 6.4 componentswith the 5.4 version of the doctrinebridge you get the following errorwhen trying to reset the entity manager:```Resetting a non-lazy manager service is not supported.Declare the "doctrine.orm.default_entity_manager" service as lazy.```The entity manager is set as lazyalready in our case but it extends `\Symfony\Component\VarExporter\LazyObjectInterface`instead of the `LazyLoadingInterface`

carsonbot added Status: Needs Review Bug DoctrineBridge labels

Dec 14, 2023

carsonbot added this to the5.4 milestone

Dec 14, 2023

maxbaldanza commented

Dec 14, 2023

View reviewed changes

src/Symfony/Bridge/Doctrine/ManagerRegistry.phpShow resolvedHide resolved

nicolas-grekas approved these changes

Dec 19, 2023

View reviewed changes

Copy link

Member

nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Works for me. This is special case because we made flex allow recent VarExporter to be combined with 5.4 apps to make it easier to upgrade to latest versions of Doctrine.

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Dec 19, 2023

Copy link

ContributorAuthor

maxbaldanza commentedDec 19, 2023

Works for me. This is special case because we made flex allow recent VarExporter to be combined with 5.4 apps to make it easier to upgrade to latest versions of Doctrine.

Thanks@nicolas-grekas 🙌