NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Mailer] [Mailjet] Disable tls for mailjet as it should use STARTTLS#53061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:6.4fromRFreij:fix/mailjet-smtp

Dec 19, 2023

Merged

[Mailer] [Mailjet] Disable tls for mailjet as it should use STARTTLS#53061

nicolas-grekas merged 1 commit intosymfony:6.4fromRFreij:fix/mailjet-smtp

Dec 19, 2023

Conversation

Copy link

Contributor

RFreij commentedDec 13, 2023•
edited
Loading

Q	A
Branch?	6.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues
License	MIT

#52560 updates the default mailjet port and references the same change for mailgun.

Similar to#51042 and with the same error message, the mailjet connection doesn't work now.

The PR above already has a reference, but for completion sake: Ref#34846 (comment) for more explanation

fix(mailjet-smtp): disable tls for mailjet as it should use starttls …

709d56f

…instead

carsonbot added Status: Needs Review Bug Mailer labels

Dec 13, 2023

carsonbot added this to the6.4 milestone

Dec 13, 2023

Copy link

carsonbot commentedDec 13, 2023

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot