Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache] Fix expiration time for CouchbaseCollection#53054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
9f26aca to3e717b8Comparenicolas-grekas added a commit that referenced this pull requestDec 18, 2023
This PR was merged into the 7.1 branch.Discussion----------[Cache] Fix CI failing tests| Q | A| ------------- | ---| Branch? | 7.1| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues | -| License | MITFixes CI, `AbstractAdapter::createConnection` checks the bucket support before falling back to Collection when the DSN starts with `couchbase`. Should fix CI in all versions with#53054Commits-------578eb29 [Cache] Fix failing test
src/Symfony/Component/Cache/Adapter/CouchbaseCollectionAdapter.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
03c665e tob958250Comparesrc/Symfony/Component/Cache/Adapter/CouchbaseCollectionAdapter.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Cache/Adapter/CouchbaseCollectionAdapter.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
b958250 toe286f38CompareMember
nicolas-grekas commentedDec 29, 2023
Thank you@alexandre-daubois. |
This was referencedDec 30, 2023
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
A refactoring has been done in Couchbase extension 3.0.5 about expiry time:https://github.com/couchbase/php-couchbase/releases/tag/v3.0.5 (see PCBC-715)
In order to put things together, let's constantly use an absolute time point here. This also fixes a failing test of integration tests in 6.3.
Tests skipping messages have been updated to match
CouchbaseCollectionAdapter::isSupported().