Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
allow Twig 4#52989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
allow Twig 4#52989
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedDec 11, 2023
| Q | A |
|---|---|
| Branch? | 7.1 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Issues | |
| License | MIT |
GromNaN left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It should work once#52987 is fixed.
derrabus commentedDec 11, 2023
Why don't we target 6.4? |
xabbuh commentedDec 11, 2023
I considered this change as a new feature. If we chose 6.4 as the target, then why not 5.4? |
fabpot commentedDec 11, 2023
Twig 4.x will probably never be released as is; this is "just" a branch that allows me to work on the next version that should be part of Symfony (7.1 hopefully). So, allowing it only on 7.1 for now works for me until we have a solid migration plan. |
derrabus commentedDec 11, 2023
We usually don't consider supporting new versions of 3rd party libraries as a new feature, but what@fabpot says makes sense to me. If Twig 4.x is a transitional branch that will eventually become symfony/twig 7.1, we should limit this change to the 7.1.x branch. |
fabpot commentedDec 17, 2023
Thank you@xabbuh. |