Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] Add sms-sluzba.cz bridge#52976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.1fromdfridrich:sms-sluzba
Dec 28, 2023
Merged

Conversation

@dfridrich
Copy link
Contributor

@dfridrichdfridrich commentedDec 9, 2023•
edited by OskarStark
Loading

QA
Branch?7.1
Bug fix?no
New feature?yes
Deprecations?no
IssuesFix#52975
LicenseMIT

Adding support forsms-sluzba.cz as I mention in

Copy link
Contributor

@OskarStarkOskarStark left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please also update UnsupportedSchemeException + test in the notifier component, thanks

It would also be very helpful if you could provide a PR againstsymfony/symfony-docs andsymfony/recipes repo.

@carsonbotcarsonbot changed the titleAdd sms-sluzba.cz Notifier Bridge[Notifier] Add sms-sluzba.cz Notifier BridgeDec 9, 2023
@OskarStarkOskarStark changed the title[Notifier] Add sms-sluzba.cz Notifier Bridge[Notifier] Add sms-sluzba.cz bridgeDec 9, 2023
dfridrich added a commit to dfridrich/symfony-docs that referenced this pull requestDec 10, 2023
Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please add your bridge toUnsupportedSchemeExceptionTest, thanks

Copy link
Member

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great. Looks good. I just have a minor comment

@OskarStark
Copy link
Contributor

Please add your bridge to UnsupportedSchemeExceptionTest, thanks

I pushed to your branch

@OskarStark
Copy link
Contributor

I fixed CS errors mentioned by fabbot.io and rebased on top of7.1

Good to merge from my side@fabpot 👍

@fabpot
Copy link
Member

Thank you@dfridrich.

@fabpotfabpot merged commitedfba7a intosymfony:7.1Dec 28, 2023
OskarStark pushed a commit to dfridrich/symfony-docs that referenced this pull requestDec 28, 2023
OskarStark added a commit to symfony/symfony-docs that referenced this pull requestDec 28, 2023
This PR was squashed before being merged into the 7.1 branch.Discussion----------[Notifier] Add docs of sms-sluzba.cz bridgesymfony/symfony#52976Commits-------9513283 [Notifier] Add docs of sms-sluzba.cz bridge
@fabpotfabpot mentioned this pull requestMay 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@NyholmNyholmNyholm left review comments

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@xabbuhxabbuhAwaiting requested review from xabbuh

+1 more reviewer

@franckranaivofranckranaivofranckranaivo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

[Notifier] Add SmsSluzba.cz support

6 participants

@dfridrich@OskarStark@fabpot@Nyholm@franckranaivo@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp