Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache] DeprecateCouchbaseBucketAdapter, useCouchbaseCollectionAdapter#52974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
875713f to3ccc634Comparesrc/Symfony/Component/Cache/Tests/Adapter/CouchbaseBucketAdapterTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
60641ff toc494606Comparenicolas-grekas approved these changesDec 10, 2023
OskarStark approved these changesDec 11, 2023
fabpot approved these changesDec 13, 2023
c494606 to78ce055CompareMember
fabpot commentedDec 13, 2023
Thank you@alexandre-daubois. |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CouchebaseBucketAdapterrequires Couches 2.x, while theCouchbaseCollectionAdapterrequires 3.x. This conflicts in the CI where both versions can't be installed. Moreover, the last release of Couchbase extension 2.x was 3 years ago (https://pecl.php.net/package/couchbase). I think it's safe to deprecate the former one and only keepCouchbaseCollectionAdapter. Couchbase 4.x support can be added eventually in another PR if someone wants to have a look 🙂