Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] Make#[AsMessageHandler] final#52971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Messenger] Make#[AsMessageHandler] final#52971
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
AsMessageHandler final#[AsMessageHandler] final
derrabus left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's also update UPGRADE-7.1.md?
RobertMe commentedDec 9, 2023
I don't think that's really the case. This "fix" changes something which didn't work into something which still doesn't work, but just for a different reason. So while it does relate to my feature request, it doesn't fix it. And I'm not even sure that the acceptation of this change would also answer my feature request. It does close of one possibility to support / implement the feature request. But it doesn't void the feature request to be able to "shortcut" Furthermore, for the reasons given by@chalasr in#52898 it is my believe thatall attribute classes should be made So to conclude it is my believe that Symfony should have some guideline / "code style" on whether (all) attribute classes must always be final, or whether they may or should be open. And in that discussion the point made by@chalasr obviously should be taken into consideration (but also that fact that said argument is already "violated" by for example all the mentioned |
3ec17f0 tof92e6c3Comparenicolas-grekas commentedDec 10, 2023
Thank you@Valmonzo. |
…Handler` (GromNaN)This PR was merged into the 7.1 branch.Discussion----------[Messenger] Allow extending attribute class `AsMessageHandler`| Q | A| ------------- | ---| Branch? | 7.1| Bug fix? | no| New feature? | yes| Deprecations? | no| Issues | -| License | MITRevert#52971 which made `AsMessageHandler` final.Discussed in#54365 (comment)Commits-------9479563 Allow extending AsMessageHandler
#SymfonyHackDay