Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpClient] AddJsonMockResponse::fromFile() andMockResponse::fromFile() shortcuts#52970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.1fromfancyweb:http-client/mock-from-file
Dec 17, 2023

Conversation

@fancyweb
Copy link
Contributor

QA
Branch?7.1
Bug fix?no
New feature?yes
Deprecations?no
Issues-
LicenseMIT

I have noticed I use a lot of file fixtures for tests since they are more readable as stand-alone files.

I think adding small shortcut methods would help the DX.

OskarStark reacted with heart emoji
@carsonbotcarsonbot added this to the7.1 milestoneDec 9, 2023
@fancywebfancywebforce-pushed thehttp-client/mock-from-file branch 3 times, most recently frome3e831f to0d7dce6CompareDecember 9, 2023 13:36
@OskarStark
Copy link
Contributor

I am not really sold on the new$json parameter 🤔 Could't we just check if the datais_string() and remove the additional parameter?

@fancyweb
Copy link
ContributorAuthor

We can't do theis_string trick because we already allow passing a string.

@fancywebfancywebforce-pushed thehttp-client/mock-from-file branch from0d7dce6 to0a9d383CompareDecember 13, 2023 14:26
@fancywebfancywebforce-pushed thehttp-client/mock-from-file branch from0a9d383 tofde8cc9CompareDecember 13, 2023 14:26
@fabpot
Copy link
Member

Thank you@fancyweb.

@fabpotfabpot merged commite595c52 intosymfony:7.1Dec 17, 2023
@fancywebfancyweb deleted the http-client/mock-from-file branchDecember 18, 2023 08:32
@fabpotfabpot mentioned this pull requestMay 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@welcoMatticwelcoMatticwelcoMattic approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

5 participants

@fancyweb@OskarStark@fabpot@welcoMattic@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp