NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[HttpClient] Add HttpOptions->addHeader as a shortcut to add an header in an existing options object#52946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:7.1fromDean151:http-client/http-options-add-header

Dec 8, 2023

Merged

[HttpClient] Add HttpOptions->addHeader as a shortcut to add an header in an existing options object#52946

fabpot merged 1 commit intosymfony:7.1fromDean151:http-client/http-options-add-header

Dec 8, 2023

Conversation

Copy link

Contributor

Dean151 commentedDec 8, 2023

Q	A
Branch?	7.1
Bug fix?	no
New feature?	yes
Deprecations?	no
Issues
License	MIT

Currently, the HttpOptions object only provide a ->setHeaders option that override every existing headers. When we are provided an HttpOptions to customize a request, adding a request header requires to get the whole headers array, update it, and then set it back in the HttpOptions object. This DX improvement brings an addHeader option, allowing to add an header to the set without having to manage the existing ones.

When the header option is not yet provided, the ??= operator makes sure the headers is initialized with an empty array (PHP >= 7.4) When a header is already provided, it is overwritten.

carsonbot added Status: Needs Review Feature HttpClient labels

Dec 8, 2023

carsonbot added this to the7.1 milestone

Dec 8, 2023

Copy link

carsonbot commentedDec 8, 2023

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot