Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Mailer] Be able to create a stream without TLS#52944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
aslangery wants to merge5 commits intosymfony:7.1fromaslangery:7.1

Conversation

aslangery
Copy link

@aslangeryaslangery commentedDec 8, 2023
edited by OskarStark
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
Issues--
LicenseMIT

It was not possible to create a stream without TLS

fix: It's not possible to create a stream without tls
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@aslangeryaslangery changed the base branch from7.1 to5.4December 8, 2023 13:19
@aslangeryaslangery changed the base branch from5.4 to7.1December 8, 2023 13:20
@OskarStarkOskarStark modified the milestones:7.1,5.4Dec 8, 2023
@carsonbotcarsonbot changed the titleFIX: It was not possible to create a stream without tls[Mailer] FIX: It was not possible to create a stream without tlsDec 8, 2023
@OskarStarkOskarStark changed the title[Mailer] FIX: It was not possible to create a stream without tls[Mailer] Be able to create a stream without TLSDec 8, 2023
@symfonysymfony deleted a comment fromcarsonbotDec 8, 2023
@OskarStark
Copy link
Contributor

Can you please add a test case? Thanks

@OskarStark
Copy link
Contributor

Why not usingàWhy don't you usingsmtps` as scheme instead? Can you explain?

@aslangery
Copy link
Author

Why not usingàWhy don't you usingsmtps` as scheme instead? Can you explain?

Our client has an incorrectly configured mail server. On swiftmailer this did not cause problems, but when switching to symfonymailer the connection stopped working

@OskarStark
Copy link
Contributor

I am not sure we want to work around wrong configured mail servers 🤔

cc@fabpot

@aslangery
Copy link
Author

I am not sure we want to work around wrong configured mail servers 🤔

cc@fabpot

This isn't really a mistake. On servers you can configure an arbitrary port for smtp. Even 465, although it is the default for smtps

@nicolas-grekasnicolas-grekas modified the milestones:5.4,7.1Jan 29, 2024
@nicolas-grekas
Copy link
Member

This might break existing client that forgot to add the final "s" to their scheme so I'm not sure I would do it this way.
Instead, we could add atls option - maybe by tweaking#53621
Closing for this reason, let's continue on the linked PR.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@lyrixxlyrixxAwaiting requested review from lyrixx

@ycerutoycerutoAwaiting requested review from yceruto

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees
No one assigned
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.

4 participants
@aslangery@carsonbot@OskarStark@nicolas-grekas

[8]ページ先頭

©2009-2025 Movatter.jp