Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Notifier] Add Seven.io bridge#52936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedDec 7, 2023
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Notifier/Exception/UnsupportedSchemeException.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
OskarStark commentedDec 8, 2023
Hi 👋 Please target 7.1 branch, as this is a new feature.
|
NeoBlack commentedDec 8, 2023
Thanks for your quick feedback, I will take care of your feedback tomorrow. |
a6173cb to72f6865CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
fabpot commentedDec 9, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Small note: this is a new feature, so it's going to be merged in 7.1, not 6.4. |
Uh oh!
There was an error while loading.Please reload this page.
NeoBlack commentedDec 9, 2023
@OskarStark@fabpot, I am having trouble running the tests locally on my machine. I am trying to understand why the tests are failing in CI. how to enable the new package for the test? |
Uh oh!
There was an error while loading.Please reload this page.
fabpot left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this is why the tests fail.
src/Symfony/Component/Notifier/Tests/Exception/UnsupportedSchemeExceptionTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
cbffdeb toa443c92Comparefabpot commentedDec 9, 2023
Like the other day, your rebase looks wrong. |
483651f to3d8cf8aCompareOskarStark commentedDec 28, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@fabpot I squashed and rebased the branch, created a docs and re recipe PR ✅ |
6b781fb to67a5120CompareSeven.io is the new name of SMS77, they changed also the URLto the gateway. To reflect that change, this patch introduces thenew Seven Notifier Bridge.The current SMS77 Bridge should be deprecated in another patch
67a5120 to83b2eb5Comparefabpot commentedDec 29, 2023
Thank you@NeoBlack. |
This PR was squashed before being merged into the 7.3 branch.Discussion----------[Notifier] Deprecate sms77 Notifier bridge| Q | A| ------------- | ---| Branch? | 7.3| Bug fix? | no| New feature? | no| Deprecations? | yes| Issues | Following#52936| License | MIT#52936 introduced a new Seven.io bridge for Notifier component to replace sms77 but this one has not been deprecatedCommits-------006ea39 [Notifier] Deprecate sms77 Notifier bridge
Uh oh!
There was an error while loading.Please reload this page.
Seven.io is the new name of SMS77, and they also changed the URL to the gateway. To reflect that change, this patch introduces the new Seven Notifier Bridge.
The current SMS77 Bridge should be deprecated in another patch.