Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Notifier] Add Seven.io bridge#52936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.1fromNeoBlack:bugfix/sms77-seven-io
Dec 29, 2023

Conversation

@NeoBlack
Copy link
Contributor

@NeoBlackNeoBlack commentedDec 7, 2023
edited by OskarStark
Loading

QA
Branch?7.1
Bug fix?no
New feature?yes
Deprecations?no
Docssymfony/symfony-docs#19351
Recipesymfony/recipes#1277
LicenseMIT

Seven.io is the new name of SMS77, and they also changed the URL to the gateway. To reflect that change, this patch introduces the new Seven Notifier Bridge.

The current SMS77 Bridge should be deprecated in another patch.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbotcarsonbot changed the title[DEPRECATION][Notifier] Add Seven Notifier Bridge and deprecate SMS77[Notifier] Add Seven Notifier Bridge and deprecate SMS77Dec 7, 2023
@OskarStarkOskarStark modified the milestones:6.4,7.1Dec 8, 2023
@OskarStarkOskarStark changed the title[Notifier] Add Seven Notifier Bridge and deprecate SMS77[Notifier] Add Seven.io Notifier Bridge and deprecate SMS77Dec 8, 2023
@OskarStark
Copy link
Contributor

Hi 👋

Please target 7.1 branch, as this is a new feature.

  1. Your new bridge need to requiresymfony/notifier^7.1
  2. Does the old bridge including the old URL still work or did the revoke the old endpoint from SMS77? If this is the case we would need a bugfix PR against the lowest maintained branch for the SMS77 bridge to keep it compatible.
  3. Lets rename it to SevenIo bridge andsevenio for scheme and package name
  4. Please remove everything related to the deprecation of the old bridge for now, thanks
NeoBlack reacted with thumbs up emoji

@OskarStarkOskarStark changed the title[Notifier] Add Seven.io Notifier Bridge and deprecate SMS77[Notifier] Add Seven.io Notifier BridgeDec 8, 2023
@NeoBlack
Copy link
ContributorAuthor

Thanks for your quick feedback, I will take care of your feedback tomorrow.

@fabpot
Copy link
Member

fabpot commentedDec 9, 2023
edited
Loading

Small note: this is a new feature, so it's going to be merged in 7.1, not 6.4.

NeoBlack reacted with thumbs up emoji

@NeoBlack
Copy link
ContributorAuthor

@OskarStark@fabpot, I am having trouble running the tests locally on my machine. I am trying to understand why the tests are failing in CI. how to enable the new package for the test?

Copy link
Member

@fabpotfabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this is why the tests fail.

@fabpot
Copy link
Member

Like the other day, your rebase looks wrong.

@OskarStarkOskarStark changed the title[Notifier] Add Seven.io Notifier Bridge[Notifier] Add Seven.io bridgeDec 28, 2023
@OskarStarkOskarStarkforce-pushed thebugfix/sms77-seven-io branch 3 times, most recently from483651f to3d8cf8aCompareDecember 28, 2023 20:41
@OskarStark
Copy link
Contributor

OskarStark commentedDec 28, 2023
edited
Loading

@fabpot I squashed and rebased the branch, created a docs and re recipe PR ✅

@OskarStarkOskarStarkforce-pushed thebugfix/sms77-seven-io branch 4 times, most recently from6b781fb to67a5120CompareDecember 28, 2023 21:41
Seven.io is the new name of SMS77, they changed also the URLto the gateway. To reflect that change, this patch introduces thenew Seven Notifier Bridge.The current SMS77 Bridge should be deprecated in another patch
@fabpot
Copy link
Member

Thank you@NeoBlack.

NeoBlack reacted with hooray emoji

@fabpotfabpot merged commit167c90b intosymfony:7.1Dec 29, 2023
@fabpotfabpot mentioned this pull requestMay 2, 2024
fabpot added a commit that referenced this pull requestMar 29, 2025
This PR was squashed before being merged into the 7.3 branch.Discussion----------[Notifier] Deprecate sms77 Notifier bridge| Q             | A| ------------- | ---| Branch?       | 7.3| Bug fix?      | no| New feature?  | no| Deprecations? | yes| Issues        | Following#52936| License       | MIT#52936 introduced a new Seven.io bridge for Notifier component to replace sms77 but this one has not been deprecatedCommits-------006ea39 [Notifier] Deprecate sms77 Notifier bridge
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

@chalasrchalasrAwaiting requested review from chalasr

@fabpotfabpotAwaiting requested review from fabpot

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

4 participants

@NeoBlack@carsonbot@OskarStark@fabpot

[8]ページ先頭

©2009-2025 Movatter.jp