Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] Fix Redis messenger scheme comparison#52930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

freswa
Copy link

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#52899
LicenseMIT

Commit3380518 introduced a new Redis Sentinel DSN for the redis messenger transport which uses a scheme syntax likeredis:?host[rs:1234]&host[rs2:1234].
Though, the coresponding factory only supports schemes which start withredis:// orrediss:// which renders the redis sentinel features for the messenger unusable. This commit fixes the supported schemes by removing the// portion of them.

fixes#52899

valtzu reacted with thumbs up emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbotcarsonbot changed the titlefix redis messenger transport bridge supports[Messenger] fix redis messenger transport bridge supportsDec 8, 2023
@OskarStarkOskarStark changed the title[Messenger] fix redis messenger transport bridge supports[Messenger] Fix Redis messenger scheme comparisonDec 8, 2023
@xabbuh
Copy link
Member

Can you please add a test (forsupports() as well as forcreateTransport())?.

@OskarStark
Copy link
Contributor

I pushed some tests

freswa reacted with heart emoji

@OskarStarkOskarStarkforce-pushed thefix-redis-sentinel-messenger-transport branch from963129f to1c821bcCompareDecember 9, 2023 11:41
@OskarStarkOskarStarkforce-pushed thefix-redis-sentinel-messenger-transport branch 2 times, most recently from68c69cd to20846e2CompareDecember 9, 2023 11:44
@freswafreswaforce-pushed thefix-redis-sentinel-messenger-transport branch 2 times, most recently from6441d08 to7477e5fCompareDecember 12, 2023 13:50
@nicolas-grekas
Copy link
Member

Please squash your PR and/or allow edits from maintainers.

Commit3380518 introduced a new Redis Sentinel DSN for the redis messenger transport which uses a scheme syntax like`redis:?host[rs:1234]&host[rs2:1234]`.Though, the coresponding factory only supports schemes which start with `redis://` or `rediss://` which renders the redis sentinel features for the messengerunusable. This commit fixes the supported schemes by removing the `//` portion of them.fixessymfony#52899
@freswafreswaforce-pushed thefix-redis-sentinel-messenger-transport branch from59ab0f9 to6f4e0a4CompareJanuary 2, 2024 13:11
@freswa
Copy link
Author

Squashed.

@nicolas-grekas
Copy link
Member

Thank you@freswa.

@nicolas-grekasnicolas-grekas merged commit712ccf5 intosymfony:6.4Jan 2, 2024
This was referencedJan 31, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@alexandre-dauboisalexandre-dauboisalexandre-daubois left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

6 participants
@freswa@carsonbot@xabbuh@OskarStark@nicolas-grekas@alexandre-daubois
[8]ページ先頭
©2009-2025 Movatter.jp