Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Dotenv] Allow environment variables starting with an underscore#52928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromxabbuh:issue-52630
Dec 28, 2023

Conversation

@xabbuh
Copy link
Member

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#52630
LicenseMIT

@carsonbotcarsonbot added this to the5.4 milestoneDec 7, 2023
@OskarStarkOskarStark changed the title[Dotenv] allow environment variables starting with an underscore[Dotenv] Allow environment variables starting with an underscoreDec 8, 2023
@OskarStark
Copy link
Contributor

This sounds like a new feature to me

Copy link
Member

@derrabusderrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Following@fabpot's remark, shall we add a test to make sure_ is not a valid env var?

OskarStark reacted with thumbs up emoji
@OskarStark
Copy link
Contributor

There is a test already

derrabus reacted with thumbs up emoji

@fabpot
Copy link
Member

Thank you@xabbuh.

@fabpotfabpot merged commitd9ce166 intosymfony:5.4Dec 28, 2023
@xabbuhxabbuh deleted the issue-52630 branchDecember 28, 2023 18:13
This was referencedDec 30, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@fabpotfabpotfabpot approved these changes

@derrabusderrabusderrabus approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@xabbuh@OskarStark@fabpot@derrabus@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp