Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] add a private_ranges shortcut for trusted_proxies#52924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:7.1fromxabbuh:issue-51826
Jan 2, 2024

Conversation

@xabbuh
Copy link
Member

QA
Branch?7.1
Bug fix?no
New feature?yes
Deprecations?no
IssuesFix#51826
LicenseMIT

dkarlovi reacted with hooray emoji
@danielburger1337
Copy link
Contributor

There are some scenarios where additional private IPs are used for reverse proxies. For example I know of multiple setups where the forwarded proxy is 127.0.0.1 (mainly Nginx -> Apache on the same machine without containerization).

There is also the case of azure load balancer. I don't know if they still actively deploy this or not but at least they used to use a little known feature called IPv6 "IPv4 mapped addresses"::ffff:0:0/96.

Wouldn't it make sense to add this to the shortcut as well? And if yes, why not just use theIpUtils::PRIVATE_SUBNETS constant? symfony/framework-bundle has a dependency on http-foundation anyways.

@xabbuh
Copy link
MemberAuthor

Wouldn't it make sense to add this to the shortcut as well? And if yes, why not just use theIpUtils::PRIVATE_SUBNETS constant? symfony/framework-bundle has a dependency on http-foundation anyways.

sounds reasonable to me, I have changed the code accordingly

danielburger1337 reacted with thumbs up emoji

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, rebase needed

@nicolas-grekas
Copy link
Member

Thank you@xabbuh.

@nicolas-grekasnicolas-grekas merged commitc8adc20 intosymfony:7.1Jan 2, 2024
@xabbuhxabbuh deleted the issue-51826 branchJanuary 2, 2024 09:38
@fabpotfabpot mentioned this pull requestMay 2, 2024
nicolas-grekas added a commit that referenced this pull requestSep 3, 2024
…or private IP address ranges to `Request::setTrustedProxies()` (nicolas-grekas)This PR was merged into the 7.2 branch.Discussion----------[HttpFoundation] Add `PRIVATE_SUBNETS` as a shortcut for private IP address ranges to `Request::setTrustedProxies()`| Q             | A| ------------- | ---| Branch?       | 7.2| Bug fix?      | no| New feature?  | no| Deprecations? | no| Issues        | -| License       | MITLet's save some memory allocations and callbacks when we can.Tweaks#33574 and#52924Commits-------6bd4b4a [HttpFoundation] Add `PRIVATE_SUBNETS` as a shortcut for private IP address ranges to `Request::setTrustedProxies()`
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

[Framework] trusted_proxies: private_ranges

4 participants

@xabbuh@danielburger1337@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp