NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

Avoid incompatibility with symfony/console 7#52923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:5.4fromjdecool:fix-console-conflict

Dec 8, 2023

Merged

Avoid incompatibility with symfony/console 7#52923

fabpot merged 1 commit intosymfony:5.4fromjdecool:fix-console-conflict

Dec 8, 2023

Conversation

Copy link

Contributor

jdecool commentedDec 7, 2023•
edited
Loading

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	-
License	MIT

The FrameworkBundle has no constraint on thesymfony/console component.

So a project can have acomposer.json similar to this one:

{"require": {"php":">=8.1","ext-ctype":"*","ext-iconv": "*","symfony/console":"^7.0","symfony/framework-bundle":"5.4.*"    },}

Using this configuration, it will install the console component in version 7.0.1 and the framework in 5.4.32.

But this error will occur:

!!!!  Fatal error: Declaration of Symfony\Bundle\FrameworkBundle\Console\Application::doRun(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony\Component\Console\Application::doRun(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int in /Users/jeremy/Workspace/personnal/bug-test/vendor/symfony/framework-bundle/Console/Application.php on line 72!!  PHP Fatal error:  Declaration of Symfony\Bundle\FrameworkBundle\Console\Application::doRun(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony\Component\Console\Application::doRun(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int in /Users/jeremy/Workspace/personnal/bug-test/vendor/symfony/framework-bundle/Console/Application.php on line 72!!  Symfony\Component\ErrorHandler\Error\FatalError {#16!!    #message: "Compile Error: Declaration of Symfony\Bundle\FrameworkBundle\Console\Application::doRun(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony\Component\Console\Application::doRun(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int"!!    #code: 0!!    #file: "./vendor/symfony/framework-bundle/Console/Application.php"!!    #line: 72!!    -error: array:4 [!!      "type" => 64!!      "message" => "Declaration of Symfony\Bundle\FrameworkBundle\Console\Application::doRun(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony\Component\Console\Application::doRun(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int"!!      "file" => "/Users/jeremy/Workspace/personnal/bug-test/vendor/symfony/framework-bundle/Console/Application.php"!!      "line" => 72!!    ]!!  }!!

So I suggest to add aconflict to avoid this issue.

Avoid incompatibility with symfony/console 7

335e8dc

carsonbot added Status: Needs Review Bug labels

Dec 7, 2023

carsonbot added this to the5.4 milestone

Dec 7, 2023

jdecool changed the title~~Avoid incompatibility with symfony/console 7~~[FrameworkBundle] Avoid incompatibility with symfony/console 7

Dec 7, 2023

jdecool mentioned this pull request

Dec 7, 2023

Fix symfony/console version to use in CI matrixnovaway/NovawayFeatureFlagBundle#68

Merged

OskarStark requested review fromnicolas-grekas andstof

December 8, 2023 09:19

stof approved these changes

Dec 8, 2023

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Dec 8, 2023

carsonbot changed the title~~[FrameworkBundle] Avoid incompatibility with symfony/console 7~~Avoid incompatibility with symfony/console 7

Dec 8, 2023

fabpot approved these changes

Dec 8, 2023

View reviewed changes

Copy link

Member

fabpot commentedDec 8, 2023

Thank you@jdecool.

fabpot merged commita3361bd intosymfony:5.4

Dec 8, 2023

jdecool deleted the fix-console-conflict branch

December 8, 2023 14:13

Copy link

Member

xabbuh commentedDec 8, 2023

Not sure how helpful this change actually is as Composer could simply stick with FrameworkBundle 5.4.32 or lower and still install version 7 of the Console component.