Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[HtmlSanitizer] Add functions to handle operations on multiple attributes and/or elements#52909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
EdouardCourty wants to merge2 commits intosymfony:7.4
base:7.4
Choose a base branch
Loading
fromEdouardCourty:7.1

Conversation

EdouardCourty
Copy link

Add functions to handle operations on multiple attributes or elements at the same time

QA
Branch?7.1
Bug fix?no
New feature?yes
Deprecations?no
IssuesNone
LicenseMIT

This branch brings supports for array parameters to handle mass allow / block / drop of elements and/or attributes.

Here is a code screenshot that shows how these news methods work:

$config =newHtmlSanitizerConfig();$attributes = ['height','width','src'];$elements = ['img',' iframe'];/* Current way */foreach ($elementsas$element) {$config =$config->allowElement($element,$attributes);}/* New way */$config =$config->allowElements($elements,$attributes);

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@EdouardCourty
Copy link
Author

By the way, why is theHtmlSanitizerConfig class usingclone statements in all its methods?
image

@stof
Copy link
Member

stof commentedDec 6, 2023

@EdouardCourty being the Config object is immutable (which means that even if you keep a reference to the Config object, you cannot mutate the configuration of a Sanitizer that has been instantiated with it)

EdouardCourty reacted with thumbs up emoji

@EdouardCourty
Copy link
Author

@EdouardCourty being the Config object is immutable (which means that even if you keep a reference to the Config object, you cannot mutate the configuration of a Sanitizer that has been instantiated with it)

Thanks for your reply, I'll fix the PR asap

…utes or elements at the same time- Wrapped some logic in private functions to stay DRY- Fixed PHPDoc comments- Fixed typo
@xabbuhxabbuh modified the milestones:7.1,7.2May 15, 2024
@fabpotfabpot modified the milestones:7.2,7.3Nov 20, 2024
@fabpotfabpot modified the milestones:7.3,7.4May 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@stofstofAwaiting requested review from stof

Assignees
No one assigned
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.

5 participants
@EdouardCourty@carsonbot@stof@fabpot@xabbuh

[8]ページ先頭

©2009-2025 Movatter.jp