NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Serializer] fix nullable int cannot be serialized#52885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:5.4fromnikophil:serializer/fix-regression

Dec 4, 2023

Merged

[Serializer] fix nullable int cannot be serialized#52885

nicolas-grekas merged 1 commit intosymfony:5.4fromnikophil:serializer/fix-regression

Dec 4, 2023

Conversation

Copy link

Contributor

nikophil commentedDec 4, 2023•
edited by nicolas-grekas
Loading

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
License	MIT

Hello,

previous tothis PR such XML could be deserialized correctly, setting null in the value:

<?xml version="1.0" encoding="UTF-8"?><DummyNullableInt><value/></DummyNullableInt>

class DummyNullableInt{publicfunction__construct(publicint|null$value =null    )    {}}

but now it creates the following error:

Uninitialized string offset 0/home/nikophil/works/symfony/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php:495/home/nikophil/works/symfony/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php:630/home/nikophil/works/symfony/src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php:377/home/nikophil/works/symfony/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php:246/home/nikophil/works/symfony/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php:346

I looked for any issue or PR mentioning this problem, but couldn't find it. So here is a fix

ping@Jeroeny

nikophil requested a review fromdunglas as acode owner

December 4, 2023 10:54

carsonbot added Status: Needs Review Bug Serializer labels

Dec 4, 2023

carsonbot added this to the7.1 milestone

Dec 4, 2023

Copy link

carsonbot commentedDec 4, 2023

Hey!

Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "6.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

nikophil changed the base branch from7.1 to6.4

December 4, 2023 10:54

xabbuh modified the milestones:7.1,6.4

Dec 4, 2023

nikophil force-pushed theserializer/fix-regression branch fromb407e62 toc3c55e8Compare

December 4, 2023 10:56

nicolas-grekas reviewed

Dec 4, 2023

View reviewed changes

Copy link

Member

nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

that's for 5.4 I suppose?
can you please rebase + retarget?

src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.phpShow resolvedHide resolved

[Serializer] fix regression where nullable int cannot be serialized

5d62dea

nikophil force-pushed theserializer/fix-regression branch fromc3c55e8 to5d62deaCompare

December 4, 2023 11:55

nikophil changed the base branch from6.4 to5.4

December 4, 2023 11:56

Copy link

ContributorAuthor

nikophil commentedDec 4, 2023

@nicolas-grekas done

the problem only occurs with nullable types properties, hence the@requires PHP 8 tag

nicolas-grekas modified the milestones:6.4,5.4

Dec 4, 2023

nicolas-grekas changed the title~~[Serializer] fix regression in 6.4 where nullable int cannot be serialized~~[Serializer] fix nullable int cannot be serialized

Dec 4, 2023