NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[AssetMapper] Improve link generation script#52869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:6.4fromsmnandre:asset-mapper-link-script

Dec 27, 2023

Merged

[AssetMapper] Improve link generation script#52869

nicolas-grekas merged 1 commit intosymfony:6.4fromsmnandre:asset-mapper-link-script

Dec 27, 2023

Conversation

Copy link

Member

smnandre commentedDec 2, 2023•
edited
Loading

Q	A
Branch?	6.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	-
License	MIT

Avoid JS console warnings due to missing comma and shorten a bit the code
(document.head is available since IE9)

Felt on it while investigating this HTTPS/2/Push thing with Firefox

(poke@weaverryan)

Update: remove the "?" after 7.1 to please carson :)
Update(bis): target 6.4 / bugfix

carsonbot added Status: Needs Review AssetMapper labels

Dec 2, 2023

carsonbot added this to the7.1 milestone

Dec 2, 2023

Copy link

carsonbot commentedDec 2, 2023

Hey!

Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "7.1 ?".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

Copy link

Member

nicolas-grekas commentedDec 4, 2023

let's do this on 6.4 as a bugfix

stof reviewed

Dec 4, 2023

View reviewed changes

src/Symfony/Component/AssetMapper/Tests/ImportMap/ImportMapRendererTest.php Outdated

		$this->assertStringContainsString('<link rel="stylesheet" href="/subdirectory/assets/styles/app-preload-d1g35t.css">',$html);
		// non-preloaded CSS file
		$this->assertStringContainsString('"app_css_no_preload": "data:application/javascript,const%20d%3Ddocument%2Cl%3Dd.createElement%28%22link%22%29%3Bl.rel%3D%22stylesheet%22%2Cl.href%3D%22%2Fsubdirectory%2Fassets%2Fstyles%2Fapp-nopreload-d1g35t.css%22%2C%28d.head%7C%7Cd.getElementsByTagName%28%22head%22%29%5B0%5D%29.appendChild%28l%29',$html);
		// $this->assertStringContainsString('"app_css_no_preload": "data:application/javascript,document.head.appendChild(Object.assign(document.createElement("link"),{rel:"stylesheet",href:"/subdirectory/assets/styles/app-nopreload-d1g35t.css"})', $html);