Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Mailer] Add Azure bridge#52842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.1fromhafael:azure-mailer-bridge
Dec 9, 2023
Merged

Conversation

@hafael
Copy link
Contributor

@hafaelhafael commentedDec 1, 2023
edited by OskarStark
Loading

QA
Branch?7.1
Bug fix?no
New feature?yes
Deprecations?no
Docssymfony/symfony-docs#19237
Recipesymfony/recipes#1265
LicenseMIT

closes#52751

This PR adds a new mailer bridge forAzure Communication Services Email

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "6.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@hafaelhafael changed the base branch from7.1 to6.4December 1, 2023 04:18
Copy link
Contributor

@OskarStarkOskarStark left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me, thank you 🙏

If you like you can open a PR againstsymfony/symfony-docs andsymfony/recipes, otherwise we can do it later

hafael reacted with thumbs up emoji
@hafael
Copy link
ContributorAuthor

hafael commentedDec 7, 2023
edited
Loading

Looks good to me, thank you 🙏

If you like you can open a PR againstsymfony/symfony-docs andsymfony/recipes, otherwise we can do it later

Thanks@OskarStark ! Thanks for the reviews so far!

OskarStark reacted with heart emoji

@OskarStark
Copy link
Contributor

Thanks@OskarStark ! Thanks for the reviews so far!

Thanks for your time ⏳

@OskarStark
Copy link
Contributor

Can you please rebase your PR?

@OskarStark
Copy link
Contributor

OskarStark commentedDec 8, 2023
edited
Loading

I added a docs and recipe PR

@hafael
Copy link
ContributorAuthor

Can you please rebase your PR?

Done!

OskarStark reacted with thumbs up emoji

@hafael
Copy link
ContributorAuthor

I added a docs and recipe PR

Thanks!

OskarStark reacted with thumbs up emoji

@fabpot
Copy link
Member

@hafael Can you rebase on 7.1, the first commit in this PR looks weird to me.

@hafael
Copy link
ContributorAuthor

@hafael Can you rebase on 7.1, the first commit in this PR looks weird to me.

Sorry, I believe I didn't understand correctly. I believe this rebase has already been done. It could be a little more descriptive as I have some limitations with GIT.

@hafaelhafaelforce-pushed theazure-mailer-bridge branch 2 times, most recently fromc283bb4 to39a162eCompareDecember 9, 2023 01:11
@hafael
Copy link
ContributorAuthor

@hafael Can you rebase on 7.1, the first commit in this PR looks weird to me.

done.

@fabpot
Copy link
Member

Thank you@hafael.

hafael reacted with hooray emoji

@fabpotfabpot merged commit088bd94 intosymfony:7.1Dec 9, 2023
@fabpotfabpot mentioned this pull requestMay 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@nicolas-grekasnicolas-grekasAwaiting requested review from nicolas-grekas

@stofstofAwaiting requested review from stof

@lyrixxlyrixxAwaiting requested review from lyrixx

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

[Mailer] Add support for Azure Communication Services Email

4 participants

@hafael@carsonbot@OskarStark@fabpot

[8]ページ先頭

©2009-2025 Movatter.jp