Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer] Do not instantiate object if it is not instantiable#52817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4frommaxbaldanza:do-not-instantiate-object
Dec 20, 2023
Merged

[Serializer] Do not instantiate object if it is not instantiable#52817

fabpot merged 1 commit intosymfony:5.4frommaxbaldanza:do-not-instantiate-object
Dec 20, 2023

Conversation

@maxbaldanza
Copy link
Contributor

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
Issues
LicenseMIT

If you pass an object that can't be instantiable such as enum to deserialize then you get the following
errorError: Cannot instantiate enum as the object is tried to be created without checking if it's instantiable

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@maxbaldanza
Copy link
ContributorAuthor

I'm not sure if the psalm error is related to something I've changed here as it fails when generating the baseline.
If it's something I've changed then let me know and I can take a look 😄

@maxbaldanza
Copy link
ContributorAuthor

@nicolas-grekas /@mtarld anything left for me to do on this one?

If you pass an object that can't be instantiable suchas enum to deserialize then you get the followingerror `Error: Cannot instantiate enum` as the objectis tried to be created without checking if it's instantiable
@fabpot
Copy link
Member

Thank you@maxbaldanza.

maxbaldanza reacted with heart emoji

@fabpotfabpot merged commit58c4522 intosymfony:5.4Dec 20, 2023
@maxbaldanzamaxbaldanza deleted the do-not-instantiate-object branchDecember 20, 2023 09:49
This was referencedDec 30, 2023
This was referencedDec 30, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@mtarldmtarldmtarld approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

@nicolas-grekasnicolas-grekasAwaiting requested review from nicolas-grekas

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@maxbaldanza@carsonbot@fabpot@nicolas-grekas@mtarld
[8]ページ先頭
©2009-2025 Movatter.jp