Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Workflow] AddgetEnabledTransition() to TraceableWorkflow#52814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:6.4fromalexandre-daubois:traceable-workflow-fixDec 1, 2023
Merged
[Workflow] AddgetEnabledTransition() to TraceableWorkflow#52814
nicolas-grekas merged 1 commit intosymfony:6.4fromalexandre-daubois:traceable-workflow-fixDec 1, 2023
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
62fc568 tof9abf62Comparelyrixx approved these changesNov 30, 2023
Member
lyrixx left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good catch, thanks 👍🏼
Uh oh!
There was an error while loading.Please reload this page.
f9abf62 tof54bc3aComparexabbuh approved these changesDec 1, 2023
Member
nicolas-grekas commentedDec 1, 2023
Thank you@alexandre-daubois. |
fabpot added a commit that referenced this pull requestDec 8, 2023
…ion to WorkflowInterface (alexandre-daubois)This PR was merged into the 7.1 branch.Discussion----------[Workflow] Add `getEnabledTransition()` method annotation to WorkflowInterface| Q | A| ------------- | ---| Branch? | 7.1| Bug fix? | no| New feature? | yes| Deprecations? | yes| Issues | -| License | MITFollowup of#52814Commits-------19abb99 [Workflow] Add `getEnabledTransition()` method annotation to WorkflowInterface
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
I added an annotation to
WorkflowInterfaceto not break BC. I think it could deserve an additionalnot implementing this method is deprecated since Symfony 7.1while upmerging (I guess ?).Added the tests while at it.