Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Routing] Fix conflicting FQCN aliases with route name#52805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@fancyweb
Copy link
Contributor

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
Issues#52801
LicenseMIT

When the route name === the FQCN alias we want to add,addAlias() throws. In this case, we can safely ignore the exception and move on.

OskarStark and asrorbekh reacted with thumbs up emoji

useSymfony\Component\Routing\Attribute\Route;

#[Route(path:'/foobarccc', name:self::class)]
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I added only this test fixture case but the 3 FQCN aliases are susceptible to fail.

@fancywebfancywebforce-pushed therouting/fix-fqcn-aliases-conflict branch from3c02106 tobb04dd5CompareNovember 29, 2023 15:45
@fancywebfancywebforce-pushed therouting/fix-fqcn-aliases-conflict branch frombb04dd5 to96a0d41CompareNovember 29, 2023 15:47
@fancywebfancywebforce-pushed therouting/fix-fqcn-aliases-conflict branch from96a0d41 to18494c8CompareNovember 29, 2023 15:48
@nicolas-grekas
Copy link
Member

Thank you@fancyweb.

@nicolas-grekasnicolas-grekas merged commit83d0106 intosymfony:6.4Nov 29, 2023
@fancywebfancyweb deleted the routing/fix-fqcn-aliases-conflict branchNovember 29, 2023 15:53
This was referencedDec 1, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@stofstofstof approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

4 participants

@fancyweb@nicolas-grekas@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp