Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Validator] Add additional versions (*_NO_PUBLIC,*_ONLY_PRIV &*_ONLY_RES) in IP address & CIDR constraint#52658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.1fromNinos:constraints-ip
Feb 3, 2024

Conversation

@Ninos
Copy link
Contributor

QA
Branch?7.1
Bug fix?no
New feature?yes
Deprecations?no
LicenseMIT

Possibility to allow no public, only private or only reserved ips.

  • Enhancement: Add*_NO_PUBLIC,*_ONLY_PRIV &*_ONLY_RES as possible versions inIp constraint
  • Enhancement: Possibility to use allIp versions inCidr constraint

See also old MR:#51777

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Almost GTM

@OskarStark
Copy link
Contributor

@nicolas-grekas rebased, cs fixed, squashed ✅

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM with a few minor comments

@Ninos
Copy link
ContributorAuthor

rebased & resolved latest comments, thank you!

@NinosNinos changed the title[Validator] Add additional versions (*_NO_PUBLIC,*_ONLY_PRIV &*_ONLY_RES) in IP address constraint[Validator] Add additional versions (*_NO_PUBLIC,*_ONLY_PRIV &*_ONLY_RES) in IP address & CIDR constraintJan 9, 2024
…*_ONLY_RES`) in IP address & CIDR constraint
@fabpot
Copy link
Member

Thank you@Ninos.

Ninos reacted with heart emoji

@fabpotfabpot merged commita770fae intosymfony:7.1Feb 3, 2024
nicolas-grekas added a commit that referenced this pull requestFeb 7, 2024
This PR was merged into the 7.1 branch.Discussion----------[Validator] revert accepting any scalar value| Q             | A| ------------- | ---| Branch?       | 7.1| Bug fix?      | no| New feature?  | no| Deprecations? | no| Issues        || License       | MITThis change sneaked into the codebase in#52658.Commits-------8d27007 revert accepting any scalar value
@fabpotfabpot mentioned this pull requestMay 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@derrabusderrabusderrabus approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

7 participants

@Ninos@OskarStark@fabpot@javiereguiluz@nicolas-grekas@derrabus@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp