Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer] Remove wrong final tags#52646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@mtarld
Copy link
Contributor

@mtarldmtarld commentedNov 20, 2023•
edited
Loading

QA
Branch?6.4
Bug fix?no
New feature?no
Deprecations?no
Issues
LicenseMIT

When@final was added toGroups andContext, the related and therefore deprecated tests weren't removed.
This PR removes them.

According to#52646 (comment),final should not have been added to attributes in the first time, this PR removes them.

@nicolas-grekas
Copy link
Member

Apparently we made a mistake : the serializer attributes should not be final. We test them usingis_a, which accounts for child classes:

privatefunctionisKnownAttribute(string$attributeName):bool
{
foreach (self::KNOWN_ATTRIBUTESas$knownAttribute) {
if (is_a($attributeName,$knownAttribute,true)) {
returntrue;
}
}
returnfalse;
}

Can you please update the PR accordingly?

mtarld and derrabus reacted with thumbs up emoji

@mtarldmtarldforce-pushed thefix/remove-deprecated-final-related-tests branch fromaade72a to74eeadaCompareNovember 20, 2023 08:09
@mtarldmtarld changed the title[Serializer] Remove deprecated final related tests[Serializer] Remove wrong final tagsNov 20, 2023
@nicolas-grekas
Copy link
Member

Thank you@mtarld.

@nicolas-grekasnicolas-grekas merged commit19c0d9a intosymfony:6.4Nov 20, 2023
@mtarldmtarld deleted the fix/remove-deprecated-final-related-tests branchNovember 20, 2023 08:33
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

4 participants

@mtarld@nicolas-grekas@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp