NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Messenger] Use extension_loaded call to check if pcntl extension is loaded, as SIGTERM might be set be swoole#52588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

derrabus merged 1 commit intosymfony:6.3fromSerheyDolgushev:fix-pcntl-check

Nov 14, 2023

Merged

[Messenger] Use extension_loaded call to check if pcntl extension is loaded, as SIGTERM might be set be swoole#52588

derrabus merged 1 commit intosymfony:6.3fromSerheyDolgushev:fix-pcntl-check

Nov 14, 2023

Conversation

Copy link

Contributor

SerheyDolgushev commentedNov 14, 2023

Q	A
Branch?	6.3
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	Fix#52586
License	MIT

It was assumed. that SIGTERM constant is set only bypcntl PHP extension. But it is also set byswoole. So in some casesSIGTERM might be set whenpcntl is disabled butswoole is enabled.

Use extension_loaded call to check if pcntl extension is loaded, as S…

d0b4fcf

…IGTERM might be set be swoole

carsonbot added Status: Needs Review Bug labels

Nov 14, 2023

carsonbot added this to the6.3 milestone

Nov 14, 2023

nicolas-grekas approved these changes

Nov 14, 2023

View reviewed changes

Copy link

Member

nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Boo on swoole for this one! :)

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Nov 14, 2023

derrabus approved these changes

Nov 14, 2023

View reviewed changes

derrabus added the Messenger label

Nov 14, 2023

carsonbot changed the title~~Use extension_loaded call to check if pcntl extension is loaded, as SIGTERM might be set be swoole~~[Messenger] Use extension_loaded call to check if pcntl extension is loaded, as SIGTERM might be set be swoole

Nov 14, 2023

Copy link

ContributorAuthor

SerheyDolgushev commentedNov 14, 2023

@derrabus thanks a lot for your patience and help on this case.

xabbuh approved these changes

Nov 14, 2023

View reviewed changes

Copy link

Member

xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

works for me, but it might be worth to also report this to Swoole

Copy link

ContributorAuthor

SerheyDolgushev commentedNov 14, 2023

works for me, but it might be worth to also report this to Swoole

In theory, there might be other PHP extensions that will setSIGTERM constant. So it is not very accurate to assume thatpcntl PHP extension is enabled ifSIGTERM is defined. It is much more straightforward and reliable to useextension_loaded for this purpose.