Hey!

Thanks for your PR. You are targeting branch "7.0" but it seems your PR description refers to branch "7.1".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

Did you consider adding the oauth token providen to core? Could this be done instead of the current extra interface? Is there an approach that wouldn't require adding this extra interface - or at least makingXOAuth2Authenticator unaware of it? I don't really like the instanceof check there 😬

Did you consider adding the oauth token providen to core? Could this be done instead of the current extra interface? Is there an approach that wouldn't require adding this extra interface - or at least making XOAuth2Authenticator unaware of it?

oauth seems to be more of a concept than an actual standard. every provider is doing it differently. if symfony had a fully fledged oauth component with support for all the major players, we could maybe make this use that. but to me an interface is really the way to go here.

oauth means sending a post with some json body to some url. but which field names to use, whats required or optional and what values to use e.g. for the scope is totally provider dependent.

for office365/exchange, the values happen to be

    private const OAUTH_URL = 'https://login.microsoftonline.com/{tenant}/oauth2/v2.0/token';    private const SCOPE = 'https://outlook.office365.com/.default';    private const GRANT_TYPE = 'client_credentials';        $data = [            'client_id' => $this->clientId,            'client_secret' => $this->clientSecret,            'scope' => self::SCOPE,            'grant_type' => self::GRANT_TYPE,        ];    // post that as x-www-form-urlencoded to    UriTemplate::expand(self::OAUTH_URL, [            'tenant' => $this->tenant,    ]));

I don't really like the instanceof check there 😬

i think the null check is required for BC.

Sorry I wrote "instanceof" but that's inaccurate. I meant this line:
https://github.com/symfony/symfony/pull/52585/files#diff-3ac0365eb0e52c96210c4fc1848acd4be3eb71ceb86aed561b76b8d1d3626b6dR42

Note that it'd be cool to contribute the office365 bridge while at it :)

Oh and maybe also an AbstractOauthTokenProvider?

thanks for the feedback. yeah that sounds good. i will try to find time, might be after christmas only 🙈

the office365 provider would go into a new Office365 namespace athttps://github.com/symfony/symfony/tree/7.1/src/Symfony/Component/Mailer/Bridge and need a composer.json for the subtree split, right?

i will see if an abstract base class makes sense that could be shared in the messenger package.

the office365 provider would go into a new Office365 namespace

yes!

Hello,@dbu@nicolas-grekas, I stumbled here while doing some research, because I am since a few days working a new component proposal, that does exactly the job of the introduced hereAuthTokenProvider, and more. Would you be interested in participating instead of adding this new interface in this PR ?

i do not have much time at the moment, so more than glad if you put some brain energy into proposing a nice architecture for the auth token system. i can try to give my input on the proposal when you have a draft ready, and will be happy to rebase this PR when/if your proposal gets merged.

@dbu thanks, I will in few days I hope, open an issue for it.

@dbu if you have a few minutes to spare, I'd very much like to have your sentiment about#54013, thanks in advance !

Did you consider adding the oauth token providen to core?

@nicolas-grekas I did ! Please see my PR#54013 - your insights would be invaluable !