Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer] Fix denormalize constructor arguments#52578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@mtarld
Copy link
Contributor

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#52499,Fix#52422
LicenseMIT

Since this PR:#51907, objects with partial constructor parameters were wrongly instantiated.

This PR fixes that issue by delegating the properties values assignment, by unsetting normalized data only when the constructor has been called properly.

This might correct#50759 as well.

pmalisak, AwesomeGogo, Havrin, and BafS reacted with thumbs up emojiAwesomeGogo, jurchiks, and denisvanmorgan reacted with hooray emoji
@mtarld
Copy link
ContributorAuthor

fabbot errors aren't related.

@mtarldmtarldforce-pushed thefix/serializer-constructor-arguments branch from7be2684 to1ad0eccCompareNovember 14, 2023 07:39
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM after minor changes

@mtarldmtarldforce-pushed thefix/serializer-constructor-arguments branch from1ad0ecc to8f7c7aeCompareNovember 20, 2023 03:15
@nicolas-grekas
Copy link
Member

Thank you@mtarld.

@nicolas-grekasnicolas-grekas merged commitb558912 intosymfony:5.4Nov 20, 2023
@mtarldmtarld deleted the fix/serializer-constructor-arguments branchNovember 20, 2023 09:30
@nicolas-grekas
Copy link
Member

@mtarld could you please have a look at the current failures on branch 6.3 for Serializer? I need help to resolve them after the merge up 🙏

@mtarld
Copy link
ContributorAuthor

Sorry@nicolas-grekas I'm in a different timezone, so I hadn't time to take of it.

But the fix provided by@xabbuh in#52665 is good (it's the one I already had on my local machine)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

3 participants

@mtarld@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp