Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[VarExporter] Drop support for partially initialized lazy object#52569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:7.0fromnicolas-grekas:ve-drop-partial
Nov 14, 2023

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?7.0
Bug fix?no
New feature?no
Deprecations?no
Issues-
LicenseMIT

Sidekick of#52568

@derrabus
Copy link
Member

⚠️ This PR will break DoctrineBundle which has already been made compatible with Symfony 7.

@nicolas-grekas
Copy link
MemberAuthor

Ah, I forgot about this one. As I wrote on another PR, ORMv3 makesLazyServiceEntityRepository useless, we should deprecate and drop it.

@derrabus
Copy link
Member

ORMv3 makesLazyServiceEntityRepository useless

Yes, but we still need a solution for ORM 2 which will stay around for a while.

we should deprecate and drop it.

LazyServiceEntityRepository is marked as internal, so we can drop that class without deprecation. If we find a way to keep the laziness ofServiceEntityRepository for ORM 2, I'm fine with the late removal of this feature. I won't have time to work on that though. 😕

@nicolas-grekasnicolas-grekasforce-pushed theve-drop-partial branch 2 times, most recently from3552e79 to364526dCompareNovember 14, 2023 12:32
@nicolas-grekasnicolas-grekas merged commitd277959 intosymfony:7.0Nov 14, 2023
@nicolas-grekasnicolas-grekas deleted the ve-drop-partial branchNovember 14, 2023 12:40
@fabpotfabpot mentioned this pull requestNov 15, 2023
@back-2-95
Copy link

So how to overcome this? My SF7 project I now need to keepsymfony/var-exporter at7.0.0-BETA1.
Or is there some release coming which would fix this?

@stof
Copy link
Member

There is an in-progress PR for DoctrineBundle.

@stof
Copy link
Member

Actually, the PR is even merged. So if you use the dev version of DoctrineBundle, it should be OK.

@back-2-95
Copy link

2.11-dev or 2.12-dev ?

@nicolas-grekas
Copy link
MemberAuthor

Here is the PR:doctrine/DoctrineBundle#1727

@stof
Copy link
Member

2.11-dev for now. The change has not yet reached 2.12-dev as the merge-up between branches has not yet been done after the merge of that PR.

back-2-95 reacted with thumbs up emoji

@back-2-95
Copy link

Ok, I required 2.11-dev for Doctrine Bundle and it worked. Now all my Symfony packages are RC1. Thanks for quick responses.

@derrabus
Copy link
Member

I've released DoctrineBundle 2.11.1 that includes the fix.

xabbuh and back-2-95 reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

5 participants

@nicolas-grekas@derrabus@back-2-95@stof@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp