Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[VarExporter] Deprecate per-property lazy-initializers#52568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
4909b25 to28a78eaCompareMember
stof commentedNov 13, 2023
Do you know any place where this feature has been used ? |
MemberAuthor
nicolas-grekas commentedNov 13, 2023
None. That's also why I'm proposing this :) |
Member
derrabus commentedNov 13, 2023
😬 |
Member
stof commentedNov 13, 2023
Looks like this is actually used... |
MemberAuthor
nicolas-grekas commentedNov 13, 2023
Here the PR to stop relying on this feature:doctrine/DoctrineBundle#1727 |
fabpot approved these changesNov 14, 2023
Member
fabpot commentedNov 14, 2023
Thank you@nicolas-grekas. |
nicolas-grekas added a commit that referenced this pull requestNov 14, 2023
…azy object (nicolas-grekas)This PR was merged into the 7.0 branch.Discussion----------[VarExporter] Drop support for partially initialized lazy object| Q | A| ------------- | ---| Branch? | 7.0| Bug fix? | no| New feature? | no| Deprecations? | no| Issues | -| License | MITSidekick of#52568Commits-------27650ef [VarExporter] Drop support for partially initialized lazy object
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
Deprecation❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze" Status: ReviewedVarExporter
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This is a very late deprecation for a complex feature that we'd better drop ASAP IMHO.
Property hooks should be a better solution, even thought it's still WIP.