NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Mailer] Update default Mailjet port#52560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:6.4fromKatario:update-default-mailjet-port

Nov 12, 2023

Merged

[Mailer] Update default Mailjet port#52560

fabpot merged 1 commit intosymfony:6.4fromKatario:update-default-mailjet-port

Nov 12, 2023

Conversation

Copy link

Contributor

Katario commentedNov 12, 2023

Q	A
Branch?	6.4
Bug fix?	no
New feature?	yes
Deprecations?	no
License	MIT

Similar to#49805, update the default to 587, which is recommended by Mailjet.
Changelog is also updated accordingly.

References:

Nowadays, port 587 is used for secure submission of email for delivery. Most of the client software are configured to use this port to send your messages.
Mailjet Blog Post about this.

[Mailer] Update default Mailjet port

1799ed2

carsonbot added Status: Needs Review Feature Mailer labels

Nov 12, 2023

carsonbot added this to the6.4 milestone

Nov 12, 2023

Copy link

carsonbot commentedNov 12, 2023

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

fabpot approved these changes

Nov 12, 2023

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Nov 12, 2023

Copy link

Member

fabpot commentedNov 12, 2023

Thank you@Katario.

fabpot merged commita3df74a intosymfony:6.4

Nov 12, 2023

This was referencedNov 12, 2023

[Mailer] Update default Mailjet portsymfony/symfony-docs#19130

Closed

Release v6.4.0-RC1#52599

Merged

Release v7.0.0-RC1#52600

Merged

RFreij mentioned this pull request

Dec 13, 2023

[Mailer] [Mailjet] Disable tls for mailjet as it should use STARTTLS#53061

Merged

nicolas-grekas added a commit that referenced this pull request

Dec 19, 2023

bug#53061[Mailer] [Mailjet] Disable tls for mailjet as it should us…

dfa5e5d

…e STARTTLS (RFreij)This PR was merged into the 6.4 branch.Discussion----------[Mailer] [Mailjet] Disable tls for mailjet as it should use STARTTLS| Q             | A| ------------- | ---| Branch?       | 6.4 <!-- see below -->| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Issues        |  <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->| License       | MIT#52560 updates the default mailjet port and references the same change for mailgun.Similar to#51042 and with the same error message, the mailjet connection doesn't work now.The PR above already has a reference, but for completion sake: Ref#34846 (comment) for more explanationCommits-------709d56f fix(mailjet-smtp): disable tls for mailjet as it should use starttls instead