Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DomCrawler] UriResolver support path with columns#52559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
derrabus commentedNov 12, 2023
Is 5.4 not affected by this bug? |
…derer)This PR was merged into the 5.4 branch.Discussion----------[Validator] Updated Lithuanian translations| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | no| New feature? | no| Deprecations? | no| Issues |Fixsymfony#51948| License | MITMissing Lithuanian translations with help from a native speaker.Commits-------5938c05 [Validator] updated Lithuanian translation
vdauchy commentedNov 13, 2023
@derrabus Fromhttps://github.com/symfony/symfony/blob/5.4/src/Symfony/Component/DomCrawler/UriResolver.php I think the but does exist in 5.4. Shall I re-do the a PR targeting 5.4 branch then the patch will be automatically applied upstream ? |
derrabus commentedNov 13, 2023
Yes, please target 5.4 then. No need to "re-do" the PR, just rebase this one and change the target. |
vdauchy commentedNov 14, 2023
Moved to#52579 |
Resolving links on pages using weird pagination like:
https://localhost/domain/search/page:5fails due to:makingReturn
false(and not null as expected in the code).This simply ensure the absolute URL is returned only if the SCHEME is found (ie a string is returned by
parse_url).