NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Form] Add`webkitdirectory` to`FileType`#52528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

danielburger1337 wants to merge1 commit intosymfony:7.0fromdanielburger1337:form-webkitdirectory

Closed

[Form] Add`webkitdirectory` to`FileType`#52528

danielburger1337 wants to merge1 commit intosymfony:7.0fromdanielburger1337:form-webkitdirectory

Conversation

Copy link

Contributor

danielburger1337 commentedNov 10, 2023

Q	A
Branch?	7.1
Bug fix?	no
New feature?	yes
Deprecations?	no
License	MIT

See#52493

Add webkitdirectory to FileType

ca3ac76

danielburger1337 requested review fromxabbuh andyceruto ascode owners

November 10, 2023 02:08

carsonbot added Status: Needs Review Feature Form labels

Nov 10, 2023

carsonbot added this to the7.0 milestone

Nov 10, 2023

Copy link

carsonbot commentedNov 10, 2023

Hey!

Thanks for your PR. You are targeting branch "7.0" but it seems your PR description refers to branch "7.1".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

Copy link

ContributorAuthor

danielburger1337 commentedNov 10, 2023

You are targeting branch "7.0" but it seems your PR description refers to branch "7.1".

Branch 7.1 doesnt exit yet. Just ignore it for now?

Copy link

Member

stof commentedNov 10, 2023•
edited
Loading

This can already be configured through theattr option, so I don't think we should add this option. We generally don't add options that just get copied into attr (for instance, we removed thereadonly option a long time ago due to that).

So -1 from me for now, unless convinced otherwise.