When we download a JS package, we check to see if that JS package has a CSS file. And if it does, we add that too. This is purely to be helpful. For example,importmap:require bootstrap grabs the Bootstrap CSS file.

A JavaScript package can explicitly advertise that it has a CSS file or jsdelivr can "guess". It tells us if it's guessing or not:

Not guessing:https://data.jsdelivr.com/v1/packages/npm/bootstrap@5.0.0/entrypoints
Yes guessing:https://data.jsdelivr.com/v1/packages/npm/tom-select@2.3.1/entrypoints

I propose we only grab the CSS file if it's a "sure thing". Right now, when you installtom-select, it's grabbing a CSS file that... we certainly don't use and I'm not sure if anyone does. It'd be better if it grabbed nothing. And, if needed (probably will be), we an make Flex install any enabled "autoimports" - e.g.https://github.com/symfony/ux/blob/2.x/src/Autocomplete/assets/package.json#L17

Overall, I'm still tweaking with the ideal UX here. I think life will be better if we only install "for sure" CSS files.

Thanks!

carsonbot added Status: Needs Review AssetMapper Bug labels

Nov 9, 2023

carsonbot added this to the6.4 milestone

Nov 9, 2023

[AssetMapper] Only download a CSS file if it is explicitly advertised

1f41d67

weaverryan force-pushed theasset-mapper-only-exact-css-files branch from335c460 to1f41d67Compare

November 10, 2023 02:35

Copy link

Contributor

WebMamba commentedNov 10, 2023

Just speaking from a DX perspective: I think we shouldALWAYS grab the CSS file. A lot of js packages have small CSS files, but without it, everything can look a bit buggy. And I think CSS is part of the packages, the maintainer chooses to add CSS in their packages, so we should follow this decision. And I think it's easier if we don't have to run two commands one to install the CSS and on for the Js.

Copy link

MemberAuthor

weaverryan commentedNov 10, 2023

And I think CSS is part of the packages, the maintainer chooses to add CSS in their packages, so we should follow this decision

I totally agree. But if that's the case, they will / should advertise that they have a CSS file - e.g. via thestyle key inpackage.json. If they haven't done this, then that's an indication that there is no one, main CSS file.