Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Config] PrefixingFileExistenceResource::__toString() to avoid conflict withFileResource#52502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:5.4fromweaverryan:config-cache-clashing-resource-stringNov 9, 2023
Merged
[Config] PrefixingFileExistenceResource::__toString() to avoid conflict withFileResource#52502
nicolas-grekas merged 1 commit intosymfony:5.4fromweaverryan:config-cache-clashing-resource-stringNov 9, 2023
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
FileExistenceResource::__toString() to avoid conflict withFileResource…ict with FileResource
a88aafd to9e8db58CompareGood catch, thanks@weaverryan. |
🚀 |
This was referencedNov 10, 2023
Merged
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Hi!
This bug causes a pretty critical AssetMapper 6.4 bug. The problem is that both
FileResourceandFileExistenceResourcereturn the same__toString()for the same file:SelfCheckingResourceChecker uses a static cache where the
ResourceInterface::__toString()is the key for that string. That creates the following bug situation:A) Something checks for
FileExistenceResourceforfoo/bar.php. This returns true andSelfCheckingResourceCheckernow hastruefor fresh in its static cacheB) Something else checks for
FileResourceforfoo/bar.php: they are checking to see if the file has beenmodified. But in instead of calling the actualFileResource::isFresh()method, it uses thetruevalue from the static cache.Cheers!