That's a new feature for sure so for 7.1
What about also adding support for thewebkitdirectory attribute in the Form component?

What about also adding support for thewebkitdirectory attribute in the Form component?

I haven't contributed to the form component yet, so I will check it out. Should be fairly simple though.

I just realized that merging this should break many legacy test cases where a file upload is manually submitted.
SeeFormTypeTest as an example. These submit the mock file upload without the "full_path" option.

Even though it is more work than simply making this option optional in FileBag, these tests SOULD be fixed because they do not adhere to the default PHP behaviour and in my opinion the FileBag should not account for that. It would also require to rework the entire logic of the FileBag.

That's a new feature for sure so for 7.1 What about also adding support for thewebkitdirectory attribute in the Form component?

See this answer from stof:#52528 (comment)

I think the failure onPsrHttpFactoryTest::testUploadErrNoFile is related, maybe the ones of Form also.
Can you please have a look?

Yeah, this failure is related. Like I mentionedhere, pretty much every test that submits a file upload manually will fail now and will have to be migrated because they don't include thefull_path key.

This is standard PHP behaviour since 8.1 and thats also the minimum required PHP version now. So I don't really see the "point" in supporting these legacy cases and they should be updated to includefull_path.

If it is the teams desire to keep this legacy behaviour, the logic of FileBag has to be heavily modified because it requires that every possible "file key" in $_FILES is included.

IMO fixing all of these test cases should be a separate PR which I'm willing to create after this is merged.

I think we could support it more gracefully by using$file['full_path'] ?? $file['name'] so that passing a file without afull_path key still works like before.

However, it might be great to update the tests emulating file uploads to include thisfull_path key.

I had a quick look at where files are submitted manually and what tests will have to be fixed:

• PsrHttpMessage (Bridge)
• Form

It looks like these aren't that many and we can literally just copy the valuename and set it tofull_path.
I changed the tests I found locally and the tests now pass.Should I add them to this PR?

BrowserKit/DomCrawler also submits files but their logic seem to be independant.

I also discoveredNativeRequestHandler in the Form component includes basically just a copy of FileBag and probably should be updated to support directory uploads as well. Add to this PR or new?

I think updating NativeRequestHandler in this PR makes sense as well.

I think we could support it more gracefully by using$file['full_path'] ?? $file['name'] so that passing a file without afull_path key still works like before.

Adding something like the following in FileBag should in theory work:

protectedfunctionconvertFileInformation(array|UploadedFile$file):array|UploadedFile|null{if ($fileinstanceof UploadedFile) {return$file;    }if (!\array_key_exists('full_path',$file) &&\array_key_exists('name',$file)) {$file['full_path'] =$file['name'];    }// ...}

This should then both work with "fixed file arrays and "normal" ones.

Thank you@danielburger1337.