Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[String] Method toByteString conversion using iconv is unreachable#52491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.4fromVincentv92:fix_52489
Nov 9, 2023
Merged

[String] Method toByteString conversion using iconv is unreachable#52491

nicolas-grekas merged 1 commit intosymfony:5.4fromVincentv92:fix_52489
Nov 9, 2023

Conversation

Vincentv92
Copy link
Contributor

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#52489
LicenseMIT

Originating from original issue:

It is possible that nobody noticed that PHP 8.0 added ValueError exceptionhttps://www.php.net/manual/en/function.mb-convert-encoding so the code is not compatible with php >= 8.0

That seems indeed to be the case

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot

This comment was marked as outdated.

@Vincentv92Vincentv92 changed the base branch from6.4 to5.4November 7, 2023 22:41
Copy link
Member

@derrabusderrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Can we add a test to prevent another regression in the future?

Vincentv92 reacted with thumbs up emoji
@derrabusderrabus modified the milestones:6.4,5.4Nov 7, 2023
@nicolas-grekas
Copy link
Member

Thank you@Vincentv92.

Vincentv92 reacted with rocket emoji

@nicolas-grekasnicolas-grekas merged commit0ff9ed4 intosymfony:5.4Nov 9, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@derrabusderrabusderrabus left review comments

@xabbuhxabbuhxabbuh approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

[String] Method toByteString conversion using iconv is unreachable
5 participants
@Vincentv92@carsonbot@nicolas-grekas@derrabus@xabbuh
[8]ページ先頭
©2009-2025 Movatter.jp